mirror of https://github.com/OpenIPC/firmware.git
663 lines
20 KiB
Diff
663 lines
20 KiB
Diff
diff -drupN a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
|
|
--- a/kernel/sched/cpufreq_schedutil.c 2018-08-06 17:23:04.000000000 +0300
|
|
+++ b/kernel/sched/cpufreq_schedutil.c 2022-06-12 05:28:14.000000000 +0300
|
|
@@ -12,14 +12,27 @@
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/cpufreq.h>
|
|
+#include <linux/kthread.h>
|
|
#include <linux/slab.h>
|
|
#include <trace/events/power.h>
|
|
|
|
#include "sched.h"
|
|
+#include "tune.h"
|
|
+
|
|
+unsigned long boosted_cpu_util(int cpu);
|
|
+
|
|
+/* Stub out fast switch routines present on mainline to reduce the backport
|
|
+ * overhead. */
|
|
+#define cpufreq_driver_fast_switch(x, y) 0
|
|
+#define cpufreq_enable_fast_switch(x)
|
|
+#define cpufreq_disable_fast_switch(x)
|
|
+#define LATENCY_MULTIPLIER (1000)
|
|
+#define SUGOV_KTHREAD_PRIORITY 50
|
|
|
|
struct sugov_tunables {
|
|
struct gov_attr_set attr_set;
|
|
- unsigned int rate_limit_us;
|
|
+ unsigned int up_rate_limit_us;
|
|
+ unsigned int down_rate_limit_us;
|
|
};
|
|
|
|
struct sugov_policy {
|
|
@@ -30,14 +43,18 @@ struct sugov_policy {
|
|
|
|
raw_spinlock_t update_lock; /* For shared policies */
|
|
u64 last_freq_update_time;
|
|
- s64 freq_update_delay_ns;
|
|
+ s64 min_rate_limit_ns;
|
|
+ s64 up_rate_delay_ns;
|
|
+ s64 down_rate_delay_ns;
|
|
unsigned int next_freq;
|
|
unsigned int cached_raw_freq;
|
|
|
|
/* The next fields are only needed if fast switch cannot be used. */
|
|
struct irq_work irq_work;
|
|
- struct work_struct work;
|
|
+ struct kthread_work work;
|
|
struct mutex work_lock;
|
|
+ struct kthread_worker worker;
|
|
+ struct task_struct *thread;
|
|
bool work_in_progress;
|
|
|
|
bool need_freq_update;
|
|
@@ -55,6 +72,11 @@ struct sugov_cpu {
|
|
unsigned long util;
|
|
unsigned long max;
|
|
unsigned int flags;
|
|
+
|
|
+ /* The field below is for single-CPU policies only. */
|
|
+#ifdef CONFIG_NO_HZ_COMMON
|
|
+ unsigned long saved_idle_calls;
|
|
+#endif
|
|
};
|
|
|
|
static DEFINE_PER_CPU(struct sugov_cpu, sugov_cpu);
|
|
@@ -79,7 +101,27 @@ static bool sugov_should_update_freq(str
|
|
}
|
|
|
|
delta_ns = time - sg_policy->last_freq_update_time;
|
|
- return delta_ns >= sg_policy->freq_update_delay_ns;
|
|
+
|
|
+ /* No need to recalculate next freq for min_rate_limit_us at least */
|
|
+ return delta_ns >= sg_policy->min_rate_limit_ns;
|
|
+}
|
|
+
|
|
+static bool sugov_up_down_rate_limit(struct sugov_policy *sg_policy, u64 time,
|
|
+ unsigned int next_freq)
|
|
+{
|
|
+ s64 delta_ns;
|
|
+
|
|
+ delta_ns = time - sg_policy->last_freq_update_time;
|
|
+
|
|
+ if (next_freq > sg_policy->next_freq &&
|
|
+ delta_ns < sg_policy->up_rate_delay_ns)
|
|
+ return true;
|
|
+
|
|
+ if (next_freq < sg_policy->next_freq &&
|
|
+ delta_ns < sg_policy->down_rate_delay_ns)
|
|
+ return true;
|
|
+
|
|
+ return false;
|
|
}
|
|
|
|
static void sugov_update_commit(struct sugov_policy *sg_policy, u64 time,
|
|
@@ -87,22 +129,26 @@ static void sugov_update_commit(struct s
|
|
{
|
|
struct cpufreq_policy *policy = sg_policy->policy;
|
|
|
|
+ if (sugov_up_down_rate_limit(sg_policy, time, next_freq)) {
|
|
+ /* Reset cached freq as next_freq isn't changed */
|
|
+ sg_policy->cached_raw_freq = 0;
|
|
+ return;
|
|
+ }
|
|
+
|
|
+ if (sg_policy->next_freq == next_freq)
|
|
+ return;
|
|
+
|
|
+ sg_policy->next_freq = next_freq;
|
|
sg_policy->last_freq_update_time = time;
|
|
|
|
if (policy->fast_switch_enabled) {
|
|
- if (sg_policy->next_freq == next_freq) {
|
|
- trace_cpu_frequency(policy->cur, smp_processor_id());
|
|
- return;
|
|
- }
|
|
- sg_policy->next_freq = next_freq;
|
|
next_freq = cpufreq_driver_fast_switch(policy, next_freq);
|
|
if (next_freq == CPUFREQ_ENTRY_INVALID)
|
|
return;
|
|
|
|
policy->cur = next_freq;
|
|
trace_cpu_frequency(next_freq, smp_processor_id());
|
|
- } else if (sg_policy->next_freq != next_freq) {
|
|
- sg_policy->next_freq = next_freq;
|
|
+ } else {
|
|
sg_policy->work_in_progress = true;
|
|
irq_work_queue(&sg_policy->irq_work);
|
|
}
|
|
@@ -110,7 +156,7 @@ static void sugov_update_commit(struct s
|
|
|
|
/**
|
|
* get_next_freq - Compute a new frequency for a given cpufreq policy.
|
|
- * @sg_cpu: schedutil cpu object to compute the new frequency for.
|
|
+ * @sg_policy: schedutil policy object to compute the new frequency for.
|
|
* @util: Current CPU utilization.
|
|
* @max: CPU capacity.
|
|
*
|
|
@@ -130,10 +176,9 @@ static void sugov_update_commit(struct s
|
|
* next_freq (as calculated above) is returned, subject to policy min/max and
|
|
* cpufreq driver limitations.
|
|
*/
|
|
-static unsigned int get_next_freq(struct sugov_cpu *sg_cpu, unsigned long util,
|
|
- unsigned long max)
|
|
+static unsigned int get_next_freq(struct sugov_policy *sg_policy,
|
|
+ unsigned long util, unsigned long max)
|
|
{
|
|
- struct sugov_policy *sg_policy = sg_cpu->sg_policy;
|
|
struct cpufreq_policy *policy = sg_policy->policy;
|
|
unsigned int freq = arch_scale_freq_invariant() ?
|
|
policy->cpuinfo.max_freq : policy->cur;
|
|
@@ -146,15 +191,36 @@ static unsigned int get_next_freq(struct
|
|
return cpufreq_driver_resolve_freq(policy, freq);
|
|
}
|
|
|
|
-static void sugov_get_util(unsigned long *util, unsigned long *max)
|
|
+static inline bool use_pelt(void)
|
|
{
|
|
- struct rq *rq = this_rq();
|
|
- unsigned long cfs_max;
|
|
+#ifdef CONFIG_SCHED_WALT
|
|
+ return (!sysctl_sched_use_walt_cpu_util || walt_disabled);
|
|
+#else
|
|
+ return true;
|
|
+#endif
|
|
+}
|
|
|
|
- cfs_max = arch_scale_cpu_capacity(NULL, smp_processor_id());
|
|
+static void sugov_get_util(unsigned long *util, unsigned long *max, u64 time)
|
|
+{
|
|
+ int cpu = smp_processor_id();
|
|
+ struct rq *rq = cpu_rq(cpu);
|
|
+ unsigned long max_cap, rt;
|
|
+ s64 delta;
|
|
|
|
- *util = min(rq->cfs.avg.util_avg, cfs_max);
|
|
- *max = cfs_max;
|
|
+ max_cap = arch_scale_cpu_capacity(NULL, cpu);
|
|
+
|
|
+ sched_avg_update(rq);
|
|
+ delta = time - rq->age_stamp;
|
|
+ if (unlikely(delta < 0))
|
|
+ delta = 0;
|
|
+ rt = div64_u64(rq->rt_avg, sched_avg_period() + delta);
|
|
+ rt = (rt * max_cap) >> SCHED_CAPACITY_SHIFT;
|
|
+
|
|
+ *util = boosted_cpu_util(cpu);
|
|
+ if (likely(use_pelt()))
|
|
+ *util = min((*util + rt), max_cap);
|
|
+
|
|
+ *max = max_cap;
|
|
}
|
|
|
|
static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time,
|
|
@@ -187,6 +253,19 @@ static void sugov_iowait_boost(struct su
|
|
sg_cpu->iowait_boost >>= 1;
|
|
}
|
|
|
|
+#ifdef CONFIG_NO_HZ_COMMON
|
|
+static bool sugov_cpu_is_busy(struct sugov_cpu *sg_cpu)
|
|
+{
|
|
+ unsigned long idle_calls = tick_nohz_get_idle_calls();
|
|
+ bool ret = idle_calls == sg_cpu->saved_idle_calls;
|
|
+
|
|
+ sg_cpu->saved_idle_calls = idle_calls;
|
|
+ return ret;
|
|
+}
|
|
+#else
|
|
+static inline bool sugov_cpu_is_busy(struct sugov_cpu *sg_cpu) { return false; }
|
|
+#endif /* CONFIG_NO_HZ_COMMON */
|
|
+
|
|
static void sugov_update_single(struct update_util_data *hook, u64 time,
|
|
unsigned int flags)
|
|
{
|
|
@@ -195,6 +274,7 @@ static void sugov_update_single(struct u
|
|
struct cpufreq_policy *policy = sg_policy->policy;
|
|
unsigned long util, max;
|
|
unsigned int next_f;
|
|
+ bool busy;
|
|
|
|
sugov_set_iowait_boost(sg_cpu, time, flags);
|
|
sg_cpu->last_update = time;
|
|
@@ -202,40 +282,40 @@ static void sugov_update_single(struct u
|
|
if (!sugov_should_update_freq(sg_policy, time))
|
|
return;
|
|
|
|
- if (flags & SCHED_CPUFREQ_RT_DL) {
|
|
+ busy = sugov_cpu_is_busy(sg_cpu);
|
|
+
|
|
+ if (flags & SCHED_CPUFREQ_DL) {
|
|
next_f = policy->cpuinfo.max_freq;
|
|
} else {
|
|
- sugov_get_util(&util, &max);
|
|
+ sugov_get_util(&util, &max, time);
|
|
sugov_iowait_boost(sg_cpu, &util, &max);
|
|
- next_f = get_next_freq(sg_cpu, util, max);
|
|
+ next_f = get_next_freq(sg_policy, util, max);
|
|
+ /*
|
|
+ * Do not reduce the frequency if the CPU has not been idle
|
|
+ * recently, as the reduction is likely to be premature then.
|
|
+ */
|
|
+ if (busy && next_f < sg_policy->next_freq) {
|
|
+ next_f = sg_policy->next_freq;
|
|
+
|
|
+ /* Reset cached freq as next_freq has changed */
|
|
+ sg_policy->cached_raw_freq = 0;
|
|
+ }
|
|
}
|
|
sugov_update_commit(sg_policy, time, next_f);
|
|
}
|
|
|
|
-static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu,
|
|
- unsigned long util, unsigned long max,
|
|
- unsigned int flags)
|
|
+static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu, u64 time)
|
|
{
|
|
struct sugov_policy *sg_policy = sg_cpu->sg_policy;
|
|
struct cpufreq_policy *policy = sg_policy->policy;
|
|
- unsigned int max_f = policy->cpuinfo.max_freq;
|
|
- u64 last_freq_update_time = sg_policy->last_freq_update_time;
|
|
+ unsigned long util = 0, max = 1;
|
|
unsigned int j;
|
|
|
|
- if (flags & SCHED_CPUFREQ_RT_DL)
|
|
- return max_f;
|
|
-
|
|
- sugov_iowait_boost(sg_cpu, &util, &max);
|
|
-
|
|
for_each_cpu(j, policy->cpus) {
|
|
- struct sugov_cpu *j_sg_cpu;
|
|
+ struct sugov_cpu *j_sg_cpu = &per_cpu(sugov_cpu, j);
|
|
unsigned long j_util, j_max;
|
|
s64 delta_ns;
|
|
|
|
- if (j == smp_processor_id())
|
|
- continue;
|
|
-
|
|
- j_sg_cpu = &per_cpu(sugov_cpu, j);
|
|
/*
|
|
* If the CPU utilization was last updated before the previous
|
|
* frequency update and the time elapsed between the last update
|
|
@@ -243,13 +323,13 @@ static unsigned int sugov_next_freq_shar
|
|
* enough, don't take the CPU into account as it probably is
|
|
* idle now (and clear iowait_boost for it).
|
|
*/
|
|
- delta_ns = last_freq_update_time - j_sg_cpu->last_update;
|
|
+ delta_ns = time - j_sg_cpu->last_update;
|
|
if (delta_ns > TICK_NSEC) {
|
|
j_sg_cpu->iowait_boost = 0;
|
|
continue;
|
|
}
|
|
- if (j_sg_cpu->flags & SCHED_CPUFREQ_RT_DL)
|
|
- return max_f;
|
|
+ if (j_sg_cpu->flags & SCHED_CPUFREQ_DL)
|
|
+ return policy->cpuinfo.max_freq;
|
|
|
|
j_util = j_sg_cpu->util;
|
|
j_max = j_sg_cpu->max;
|
|
@@ -261,7 +341,7 @@ static unsigned int sugov_next_freq_shar
|
|
sugov_iowait_boost(j_sg_cpu, &util, &max);
|
|
}
|
|
|
|
- return get_next_freq(sg_cpu, util, max);
|
|
+ return get_next_freq(sg_policy, util, max);
|
|
}
|
|
|
|
static void sugov_update_shared(struct update_util_data *hook, u64 time,
|
|
@@ -272,7 +352,7 @@ static void sugov_update_shared(struct u
|
|
unsigned long util, max;
|
|
unsigned int next_f;
|
|
|
|
- sugov_get_util(&util, &max);
|
|
+ sugov_get_util(&util, &max, time);
|
|
|
|
raw_spin_lock(&sg_policy->update_lock);
|
|
|
|
@@ -284,14 +364,18 @@ static void sugov_update_shared(struct u
|
|
sg_cpu->last_update = time;
|
|
|
|
if (sugov_should_update_freq(sg_policy, time)) {
|
|
- next_f = sugov_next_freq_shared(sg_cpu, util, max, flags);
|
|
+ if (flags & SCHED_CPUFREQ_DL)
|
|
+ next_f = sg_policy->policy->cpuinfo.max_freq;
|
|
+ else
|
|
+ next_f = sugov_next_freq_shared(sg_cpu, time);
|
|
+
|
|
sugov_update_commit(sg_policy, time, next_f);
|
|
}
|
|
|
|
raw_spin_unlock(&sg_policy->update_lock);
|
|
}
|
|
|
|
-static void sugov_work(struct work_struct *work)
|
|
+static void sugov_work(struct kthread_work *work)
|
|
{
|
|
struct sugov_policy *sg_policy = container_of(work, struct sugov_policy, work);
|
|
|
|
@@ -308,7 +392,21 @@ static void sugov_irq_work(struct irq_wo
|
|
struct sugov_policy *sg_policy;
|
|
|
|
sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
|
|
- schedule_work_on(smp_processor_id(), &sg_policy->work);
|
|
+
|
|
+ /*
|
|
+ * For RT and deadline tasks, the schedutil governor shoots the
|
|
+ * frequency to maximum. Special care must be taken to ensure that this
|
|
+ * kthread doesn't result in the same behavior.
|
|
+ *
|
|
+ * This is (mostly) guaranteed by the work_in_progress flag. The flag is
|
|
+ * updated only at the end of the sugov_work() function and before that
|
|
+ * the schedutil governor rejects all other frequency scaling requests.
|
|
+ *
|
|
+ * There is a very rare case though, where the RT thread yields right
|
|
+ * after the work_in_progress flag is cleared. The effects of that are
|
|
+ * neglected for now.
|
|
+ */
|
|
+ kthread_queue_work(&sg_policy->worker, &sg_policy->work);
|
|
}
|
|
|
|
/************************** sysfs interface ************************/
|
|
@@ -321,15 +419,32 @@ static inline struct sugov_tunables *to_
|
|
return container_of(attr_set, struct sugov_tunables, attr_set);
|
|
}
|
|
|
|
-static ssize_t rate_limit_us_show(struct gov_attr_set *attr_set, char *buf)
|
|
+static DEFINE_MUTEX(min_rate_lock);
|
|
+
|
|
+static void update_min_rate_limit_us(struct sugov_policy *sg_policy)
|
|
+{
|
|
+ mutex_lock(&min_rate_lock);
|
|
+ sg_policy->min_rate_limit_ns = min(sg_policy->up_rate_delay_ns,
|
|
+ sg_policy->down_rate_delay_ns);
|
|
+ mutex_unlock(&min_rate_lock);
|
|
+}
|
|
+
|
|
+static ssize_t up_rate_limit_us_show(struct gov_attr_set *attr_set, char *buf)
|
|
{
|
|
struct sugov_tunables *tunables = to_sugov_tunables(attr_set);
|
|
|
|
- return sprintf(buf, "%u\n", tunables->rate_limit_us);
|
|
+ return sprintf(buf, "%u\n", tunables->up_rate_limit_us);
|
|
}
|
|
|
|
-static ssize_t rate_limit_us_store(struct gov_attr_set *attr_set, const char *buf,
|
|
- size_t count)
|
|
+static ssize_t down_rate_limit_us_show(struct gov_attr_set *attr_set, char *buf)
|
|
+{
|
|
+ struct sugov_tunables *tunables = to_sugov_tunables(attr_set);
|
|
+
|
|
+ return sprintf(buf, "%u\n", tunables->down_rate_limit_us);
|
|
+}
|
|
+
|
|
+static ssize_t up_rate_limit_us_store(struct gov_attr_set *attr_set,
|
|
+ const char *buf, size_t count)
|
|
{
|
|
struct sugov_tunables *tunables = to_sugov_tunables(attr_set);
|
|
struct sugov_policy *sg_policy;
|
|
@@ -338,18 +453,42 @@ static ssize_t rate_limit_us_store(struc
|
|
if (kstrtouint(buf, 10, &rate_limit_us))
|
|
return -EINVAL;
|
|
|
|
- tunables->rate_limit_us = rate_limit_us;
|
|
+ tunables->up_rate_limit_us = rate_limit_us;
|
|
|
|
- list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook)
|
|
- sg_policy->freq_update_delay_ns = rate_limit_us * NSEC_PER_USEC;
|
|
+ list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook) {
|
|
+ sg_policy->up_rate_delay_ns = rate_limit_us * NSEC_PER_USEC;
|
|
+ update_min_rate_limit_us(sg_policy);
|
|
+ }
|
|
|
|
return count;
|
|
}
|
|
|
|
-static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
|
|
+static ssize_t down_rate_limit_us_store(struct gov_attr_set *attr_set,
|
|
+ const char *buf, size_t count)
|
|
+{
|
|
+ struct sugov_tunables *tunables = to_sugov_tunables(attr_set);
|
|
+ struct sugov_policy *sg_policy;
|
|
+ unsigned int rate_limit_us;
|
|
+
|
|
+ if (kstrtouint(buf, 10, &rate_limit_us))
|
|
+ return -EINVAL;
|
|
+
|
|
+ tunables->down_rate_limit_us = rate_limit_us;
|
|
+
|
|
+ list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook) {
|
|
+ sg_policy->down_rate_delay_ns = rate_limit_us * NSEC_PER_USEC;
|
|
+ update_min_rate_limit_us(sg_policy);
|
|
+ }
|
|
+
|
|
+ return count;
|
|
+}
|
|
+
|
|
+static struct governor_attr up_rate_limit_us = __ATTR_RW(up_rate_limit_us);
|
|
+static struct governor_attr down_rate_limit_us = __ATTR_RW(down_rate_limit_us);
|
|
|
|
static struct attribute *sugov_attributes[] = {
|
|
- &rate_limit_us.attr,
|
|
+ &up_rate_limit_us.attr,
|
|
+ &down_rate_limit_us.attr,
|
|
NULL
|
|
};
|
|
|
|
@@ -371,19 +510,64 @@ static struct sugov_policy *sugov_policy
|
|
return NULL;
|
|
|
|
sg_policy->policy = policy;
|
|
- init_irq_work(&sg_policy->irq_work, sugov_irq_work);
|
|
- INIT_WORK(&sg_policy->work, sugov_work);
|
|
- mutex_init(&sg_policy->work_lock);
|
|
raw_spin_lock_init(&sg_policy->update_lock);
|
|
return sg_policy;
|
|
}
|
|
|
|
static void sugov_policy_free(struct sugov_policy *sg_policy)
|
|
{
|
|
- mutex_destroy(&sg_policy->work_lock);
|
|
kfree(sg_policy);
|
|
}
|
|
|
|
+static int sugov_kthread_create(struct sugov_policy *sg_policy)
|
|
+{
|
|
+ struct task_struct *thread;
|
|
+ struct sched_param param = { .sched_priority = MAX_USER_RT_PRIO / 2 };
|
|
+ struct cpufreq_policy *policy = sg_policy->policy;
|
|
+ int ret;
|
|
+
|
|
+ /* kthread only required for slow path */
|
|
+ if (policy->fast_switch_enabled)
|
|
+ return 0;
|
|
+
|
|
+ kthread_init_work(&sg_policy->work, sugov_work);
|
|
+ kthread_init_worker(&sg_policy->worker);
|
|
+ thread = kthread_create(kthread_worker_fn, &sg_policy->worker,
|
|
+ "sugov:%d",
|
|
+ cpumask_first(policy->related_cpus));
|
|
+ if (IS_ERR(thread)) {
|
|
+ pr_err("failed to create sugov thread: %ld\n", PTR_ERR(thread));
|
|
+ return PTR_ERR(thread);
|
|
+ }
|
|
+
|
|
+ ret = sched_setscheduler_nocheck(thread, SCHED_FIFO, ¶m);
|
|
+ if (ret) {
|
|
+ kthread_stop(thread);
|
|
+ pr_warn("%s: failed to set SCHED_FIFO\n", __func__);
|
|
+ return ret;
|
|
+ }
|
|
+
|
|
+ sg_policy->thread = thread;
|
|
+ kthread_bind_mask(thread, policy->related_cpus);
|
|
+ init_irq_work(&sg_policy->irq_work, sugov_irq_work);
|
|
+ mutex_init(&sg_policy->work_lock);
|
|
+
|
|
+ wake_up_process(thread);
|
|
+
|
|
+ return 0;
|
|
+}
|
|
+
|
|
+static void sugov_kthread_stop(struct sugov_policy *sg_policy)
|
|
+{
|
|
+ /* kthread only required for slow path */
|
|
+ if (sg_policy->policy->fast_switch_enabled)
|
|
+ return;
|
|
+
|
|
+ kthread_flush_worker(&sg_policy->worker);
|
|
+ kthread_stop(sg_policy->thread);
|
|
+ mutex_destroy(&sg_policy->work_lock);
|
|
+}
|
|
+
|
|
static struct sugov_tunables *sugov_tunables_alloc(struct sugov_policy *sg_policy)
|
|
{
|
|
struct sugov_tunables *tunables;
|
|
@@ -409,23 +593,30 @@ static int sugov_init(struct cpufreq_pol
|
|
{
|
|
struct sugov_policy *sg_policy;
|
|
struct sugov_tunables *tunables;
|
|
- unsigned int lat;
|
|
int ret = 0;
|
|
|
|
/* State should be equivalent to EXIT */
|
|
if (policy->governor_data)
|
|
return -EBUSY;
|
|
|
|
+ cpufreq_enable_fast_switch(policy);
|
|
+
|
|
sg_policy = sugov_policy_alloc(policy);
|
|
- if (!sg_policy)
|
|
- return -ENOMEM;
|
|
+ if (!sg_policy) {
|
|
+ ret = -ENOMEM;
|
|
+ goto disable_fast_switch;
|
|
+ }
|
|
+
|
|
+ ret = sugov_kthread_create(sg_policy);
|
|
+ if (ret)
|
|
+ goto free_sg_policy;
|
|
|
|
mutex_lock(&global_tunables_lock);
|
|
|
|
if (global_tunables) {
|
|
if (WARN_ON(have_governor_per_policy())) {
|
|
ret = -EINVAL;
|
|
- goto free_sg_policy;
|
|
+ goto stop_kthread;
|
|
}
|
|
policy->governor_data = sg_policy;
|
|
sg_policy->tunables = global_tunables;
|
|
@@ -437,13 +628,23 @@ static int sugov_init(struct cpufreq_pol
|
|
tunables = sugov_tunables_alloc(sg_policy);
|
|
if (!tunables) {
|
|
ret = -ENOMEM;
|
|
- goto free_sg_policy;
|
|
+ goto stop_kthread;
|
|
}
|
|
|
|
- tunables->rate_limit_us = LATENCY_MULTIPLIER;
|
|
- lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC;
|
|
- if (lat)
|
|
- tunables->rate_limit_us *= lat;
|
|
+ if (policy->up_transition_delay_us && policy->down_transition_delay_us) {
|
|
+ tunables->up_rate_limit_us = policy->up_transition_delay_us;
|
|
+ tunables->down_rate_limit_us = policy->down_transition_delay_us;
|
|
+ } else {
|
|
+ unsigned int lat;
|
|
+
|
|
+ tunables->up_rate_limit_us = LATENCY_MULTIPLIER;
|
|
+ tunables->down_rate_limit_us = LATENCY_MULTIPLIER;
|
|
+ lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC;
|
|
+ if (lat) {
|
|
+ tunables->up_rate_limit_us *= lat;
|
|
+ tunables->down_rate_limit_us *= lat;
|
|
+ }
|
|
+ }
|
|
|
|
policy->governor_data = sg_policy;
|
|
sg_policy->tunables = tunables;
|
|
@@ -454,20 +655,25 @@ static int sugov_init(struct cpufreq_pol
|
|
if (ret)
|
|
goto fail;
|
|
|
|
- out:
|
|
+out:
|
|
mutex_unlock(&global_tunables_lock);
|
|
-
|
|
- cpufreq_enable_fast_switch(policy);
|
|
return 0;
|
|
|
|
- fail:
|
|
+fail:
|
|
policy->governor_data = NULL;
|
|
sugov_tunables_free(tunables);
|
|
|
|
+ stop_kthread:
|
|
+ sugov_kthread_stop(sg_policy);
|
|
+
|
|
free_sg_policy:
|
|
mutex_unlock(&global_tunables_lock);
|
|
|
|
sugov_policy_free(sg_policy);
|
|
+
|
|
+disable_fast_switch:
|
|
+ cpufreq_disable_fast_switch(policy);
|
|
+
|
|
pr_err("initialization failed (error %d)\n", ret);
|
|
return ret;
|
|
}
|
|
@@ -478,8 +684,6 @@ static void sugov_exit(struct cpufreq_po
|
|
struct sugov_tunables *tunables = sg_policy->tunables;
|
|
unsigned int count;
|
|
|
|
- cpufreq_disable_fast_switch(policy);
|
|
-
|
|
mutex_lock(&global_tunables_lock);
|
|
|
|
count = gov_attr_set_put(&tunables->attr_set, &sg_policy->tunables_hook);
|
|
@@ -489,7 +693,10 @@ static void sugov_exit(struct cpufreq_po
|
|
|
|
mutex_unlock(&global_tunables_lock);
|
|
|
|
+ sugov_kthread_stop(sg_policy);
|
|
sugov_policy_free(sg_policy);
|
|
+
|
|
+ cpufreq_disable_fast_switch(policy);
|
|
}
|
|
|
|
static int sugov_start(struct cpufreq_policy *policy)
|
|
@@ -497,7 +704,11 @@ static int sugov_start(struct cpufreq_po
|
|
struct sugov_policy *sg_policy = policy->governor_data;
|
|
unsigned int cpu;
|
|
|
|
- sg_policy->freq_update_delay_ns = sg_policy->tunables->rate_limit_us * NSEC_PER_USEC;
|
|
+ sg_policy->up_rate_delay_ns =
|
|
+ sg_policy->tunables->up_rate_limit_us * NSEC_PER_USEC;
|
|
+ sg_policy->down_rate_delay_ns =
|
|
+ sg_policy->tunables->down_rate_limit_us * NSEC_PER_USEC;
|
|
+ update_min_rate_limit_us(sg_policy);
|
|
sg_policy->last_freq_update_time = 0;
|
|
sg_policy->next_freq = UINT_MAX;
|
|
sg_policy->work_in_progress = false;
|
|
@@ -509,7 +720,7 @@ static int sugov_start(struct cpufreq_po
|
|
|
|
memset(sg_cpu, 0, sizeof(*sg_cpu));
|
|
sg_cpu->sg_policy = sg_policy;
|
|
- sg_cpu->flags = SCHED_CPUFREQ_RT;
|
|
+ sg_cpu->flags = SCHED_CPUFREQ_DL;
|
|
sg_cpu->iowait_boost_max = policy->cpuinfo.max_freq;
|
|
cpufreq_add_update_util_hook(cpu, &sg_cpu->update_util,
|
|
policy_is_shared(policy) ?
|
|
@@ -529,8 +740,10 @@ static void sugov_stop(struct cpufreq_po
|
|
|
|
synchronize_sched();
|
|
|
|
- irq_work_sync(&sg_policy->irq_work);
|
|
- cancel_work_sync(&sg_policy->work);
|
|
+ if (!policy->fast_switch_enabled) {
|
|
+ irq_work_sync(&sg_policy->irq_work);
|
|
+ kthread_cancel_work_sync(&sg_policy->work);
|
|
+ }
|
|
}
|
|
|
|
static void sugov_limits(struct cpufreq_policy *policy)
|